Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct spelling errors for temperature units #665

Merged
merged 3 commits into from
Jul 16, 2024
Merged

fix: correct spelling errors for temperature units #665

merged 3 commits into from
Jul 16, 2024

Conversation

badrbouslikhin
Copy link
Contributor

@badrbouslikhin badrbouslikhin commented Jul 14, 2024 •
edited
Loading

What does this do?

This PR corrects the spelling errors for temperature units in formatunits.py:

  • CELSUIS to CELSIUS
  • FARENHEIT to FAHRENHEIT

Questions

  • This a breaking change. Anything specific to handle it?

JamesGibo
JamesGibo requested changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution would you be able to add a note to the changelog for this breaking change?

@badrbouslikhin
Copy link
Contributor Author

badrbouslikhin commented Jul 16, 2024 •
edited
Loading

Done.
Thanks for your quick review!

@JamesGibo JamesGibo merged commit 16e2bcf into weaveworks:main Jul 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesGibo JamesGibo JamesGibo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badrbouslikhin @JamesGibo